angelandClaude Sonnet 5
a9b51bcad9
Replaces raw t.Error/t.Errorf/t.Fatal/t.Fatalf across every test file that has any (domains/accounts, domains/authentication, domains/raw_events, domains/amazon, domains/reports x2) with testify's assert (non-halting) / require (halting) equivalents. The three Example-based tests (server/ui/svg, server/ui/charts) have no *testing.T at all - nothing to convert there. require.Eventually replaces several hand-rolled polling loops in domains/amazon/mock_test.go. Its condition function runs on a separate goroutine (confirmed in testify's source), so calling require.* from inside one - which two of the new Eventually calls initially did, via the isProcessed helper - is unsafe per Go's testing rules (t.FailNow must only be called from the test's own goroutine). Fixed by splitting a *testing.T-free queryIsProcessed(ctx, pool, shopID, eventID) out of isProcessed for use inside those closures specifically. github.com/stretchr/testify promoted from an indirect to a direct dependency (go.mod only - it was already present transitively, so go.sum is unchanged). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XEDaCB7C2NEBgyvqEtZuxY
75 lines
2.7 KiB
Go
75 lines
2.7 KiB
Go
package authentication
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"ruben/inventory2/consts"
|
|
"ruben/inventory2/internal/testdb"
|
|
)
|
|
|
|
func TestDevLogin(t *testing.T) {
|
|
pool := testdb.Pool(t)
|
|
auth := &Authenticator{db: pool}
|
|
ctx := context.Background()
|
|
|
|
userID := testdb.NewUserID(t)
|
|
t.Cleanup(func() {
|
|
pool.Exec(context.Background(), "DELETE FROM oauth_tokens WHERE id_token_subject = $1", userID)
|
|
pool.Exec(context.Background(), "DELETE FROM oauth_users WHERE user_id = $1", userID)
|
|
})
|
|
|
|
accessToken, expiration, err := auth.DevLogin(ctx, userID, "Test User")
|
|
require.NoError(t, err, "DevLogin()")
|
|
require.NotEmpty(t, accessToken, "DevLogin() returned an empty access token")
|
|
assert.True(t, expiration.After(time.Now().Add(30*24*time.Hour)),
|
|
"DevLogin() expiration = %v, want something far enough out to avoid the near-expiry refresh path", expiration)
|
|
|
|
claims, err := auth.GetAccessTokenClaimsAndExpiration(ctx, accessToken)
|
|
require.NoError(t, err, "GetAccessTokenClaimsAndExpiration()")
|
|
assert.Equal(t, "Test User", claims.Name, "claims.Name")
|
|
// Postgres timestamptz has microsecond precision, so the round-tripped
|
|
// value loses the sub-microsecond portion of Go's nanosecond clock.
|
|
assert.WithinDuration(t, expiration, claims.Expiration, time.Millisecond, "claims.Expiration")
|
|
|
|
_, tokenType, err := auth.getRefreshTokenForAccessToken(ctx, accessToken)
|
|
require.NoError(t, err, "getRefreshTokenForAccessToken()")
|
|
assert.Equal(t, "dev", tokenType, "tokenType")
|
|
}
|
|
|
|
// DevLogin should be safe to call more than once for the same user_id -
|
|
// e.g. testing multiple times as the same dev identity - since oauth_users
|
|
// is keyed on user_id but each call mints its own oauth_tokens row.
|
|
func TestDevLogin_SameUserIDTwice(t *testing.T) {
|
|
pool := testdb.Pool(t)
|
|
auth := &Authenticator{db: pool}
|
|
ctx := context.Background()
|
|
|
|
userID := testdb.NewUserID(t)
|
|
t.Cleanup(func() {
|
|
pool.Exec(context.Background(), "DELETE FROM oauth_tokens WHERE id_token_subject = $1", userID)
|
|
pool.Exec(context.Background(), "DELETE FROM oauth_users WHERE user_id = $1", userID)
|
|
})
|
|
|
|
token1, _, err := auth.DevLogin(ctx, userID, "Test User")
|
|
require.NoError(t, err, "first DevLogin()")
|
|
|
|
token2, _, err := auth.DevLogin(ctx, userID, "Test User")
|
|
require.NoError(t, err, "second DevLogin()")
|
|
|
|
assert.NotEqual(t, token1, token2, "DevLogin() returned the same access token twice")
|
|
}
|
|
|
|
func TestGetAccessTokenClaimsAndExpiration_UnknownToken(t *testing.T) {
|
|
pool := testdb.Pool(t)
|
|
auth := &Authenticator{db: pool}
|
|
ctx := context.Background()
|
|
|
|
_, err := auth.GetAccessTokenClaimsAndExpiration(ctx, "no-such-token-"+testdb.NewUserID(t))
|
|
require.ErrorIs(t, err, consts.ErrNotFound, "GetAccessTokenClaimsAndExpiration()")
|
|
}
|