tests: migrate assertions to testify's assert/require

Replaces raw t.Error/t.Errorf/t.Fatal/t.Fatalf across every test file
that has any (domains/accounts, domains/authentication,
domains/raw_events, domains/amazon, domains/reports x2) with testify's
assert (non-halting) / require (halting) equivalents. The three
Example-based tests (server/ui/svg, server/ui/charts) have no
*testing.T at all - nothing to convert there.

require.Eventually replaces several hand-rolled polling loops in
domains/amazon/mock_test.go. Its condition function runs on a separate
goroutine (confirmed in testify's source), so calling require.* from
inside one - which two of the new Eventually calls initially did, via
the isProcessed helper - is unsafe per Go's testing rules (t.FailNow
must only be called from the test's own goroutine). Fixed by splitting
a *testing.T-free queryIsProcessed(ctx, pool, shopID, eventID) out of
isProcessed for use inside those closures specifically.

github.com/stretchr/testify promoted from an indirect to a direct
dependency (go.mod only - it was already present transitively, so
go.sum is unchanged).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XEDaCB7C2NEBgyvqEtZuxY

domains/authentication/dev_test.go

@@ -2,10 +2,12 @@ package authentication
 
 import (
 	"context"
-	"errors"
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
 	"ruben/inventory2/consts"
 	"ruben/inventory2/internal/testdb"
 )
@@ -22,36 +24,21 @@ func TestDevLogin(t *testing.T) {
 	})
 
 	accessToken, expiration, err := auth.DevLogin(ctx, userID, "Test User")
-	if err != nil {
-		t.Fatalf("DevLogin() error = %v", err)
-	}
-	if accessToken == "" {
-		t.Fatal("DevLogin() returned an empty access token")
-	}
-	if !expiration.After(time.Now().Add(30 * 24 * time.Hour)) {
-		t.Errorf("DevLogin() expiration = %v, want something far enough out to avoid the near-expiry refresh path", expiration)
-	}
+	require.NoError(t, err, "DevLogin()")
+	require.NotEmpty(t, accessToken, "DevLogin() returned an empty access token")
+	assert.True(t, expiration.After(time.Now().Add(30*24*time.Hour)),
+		"DevLogin() expiration = %v, want something far enough out to avoid the near-expiry refresh path", expiration)
 
 	claims, err := auth.GetAccessTokenClaimsAndExpiration(ctx, accessToken)
-	if err != nil {
-		t.Fatalf("GetAccessTokenClaimsAndExpiration() error = %v", err)
-	}
-	if claims.Name != "Test User" {
-		t.Errorf("claims.Name = %q, want %q", claims.Name, "Test User")
-	}
+	require.NoError(t, err, "GetAccessTokenClaimsAndExpiration()")
+	assert.Equal(t, "Test User", claims.Name, "claims.Name")
 	// Postgres timestamptz has microsecond precision, so the round-tripped
 	// value loses the sub-microsecond portion of Go's nanosecond clock.
-	if diff := claims.Expiration.Sub(expiration); diff > time.Millisecond || diff < -time.Millisecond {
-		t.Errorf("claims.Expiration = %v, want ~%v (diff %v)", claims.Expiration, expiration, diff)
-	}
+	assert.WithinDuration(t, expiration, claims.Expiration, time.Millisecond, "claims.Expiration")
 
 	_, tokenType, err := auth.getRefreshTokenForAccessToken(ctx, accessToken)
-	if err != nil {
-		t.Fatalf("getRefreshTokenForAccessToken() error = %v", err)
-	}
-	if tokenType != "dev" {
-		t.Errorf("tokenType = %q, want %q", tokenType, "dev")
-	}
+	require.NoError(t, err, "getRefreshTokenForAccessToken()")
+	assert.Equal(t, "dev", tokenType, "tokenType")
 }
 
 // DevLogin should be safe to call more than once for the same user_id -
@@ -69,18 +56,12 @@ func TestDevLogin_SameUserIDTwice(t *testing.T) {
 	})
 
 	token1, _, err := auth.DevLogin(ctx, userID, "Test User")
-	if err != nil {
-		t.Fatalf("first DevLogin() error = %v", err)
-	}
+	require.NoError(t, err, "first DevLogin()")
 
 	token2, _, err := auth.DevLogin(ctx, userID, "Test User")
-	if err != nil {
-		t.Fatalf("second DevLogin() error = %v", err)
-	}
+	require.NoError(t, err, "second DevLogin()")
 
-	if token1 == token2 {
-		t.Fatalf("DevLogin() returned the same access token twice: %q", token1)
-	}
+	assert.NotEqual(t, token1, token2, "DevLogin() returned the same access token twice")
 }
 
 func TestGetAccessTokenClaimsAndExpiration_UnknownToken(t *testing.T) {
@@ -89,7 +70,5 @@ func TestGetAccessTokenClaimsAndExpiration_UnknownToken(t *testing.T) {
 	ctx := context.Background()
 
 	_, err := auth.GetAccessTokenClaimsAndExpiration(ctx, "no-such-token-"+testdb.NewUserID(t))
-	if !errors.Is(err, consts.ErrNotFound) {
-		t.Fatalf("GetAccessTokenClaimsAndExpiration() error = %v, want %v", err, consts.ErrNotFound)
-	}
+	require.ErrorIs(t, err, consts.ErrNotFound, "GetAccessTokenClaimsAndExpiration()")
 }