Claude-assisted improvements (untested)

- dev auth flow (side-step OAuth) - db event processing integration tests - dev scripts (eg Makefile) - db / test db migration setup scripts.
2026-08-19 23:20:15 -06:00
parent 82efe19ae0
commit 4e77052a37
35 changed files with 1242 additions and 144 deletions
@@ -0,0 +1,15 @@
+# Work Summary — 2026-08-04 22:56
+
+## Task
+Address the two `go vet` "unreachable code" warnings that have been showing up alongside test runs since the test-coverage work started surfacing them.
+
+## Changes
+Both were leftover dead `return` statements after the surrounding logic was later changed to already return on every path - simple deletions, no behavior change:
+
+- `domains/accounts/accounts.go:1472` (in `SetListingInListingInMockSyncGroupBeingEdited`'s per-schema update loop): a trailing `return nil` after a `switch` whose three cases (`continue`/`return nil`/`return fmt.Errorf(...)`) already cover every value of `RowsAffected()`. Removed the dead line.
+- `server/sse/publisher.go:141` (`Push`): a `return nil` sitting after `return errors.Join(errs...)`, which already unconditionally returns. Removed the dead line - `errors.Join(errs...)` was the intended return value all along (returns `nil` itself when `errs` has no non-nil entries, so behavior is unchanged).
+
+## Verification
+- `go build ./...` clean.
+- `go vet ./...` now fully clean (previously exactly these two warnings).
+- `make test`: full suite still green, no regressions.